[PATCH] drm/radeon: s2disk: Leave hw powered between freeze()

Oliver Winker oliverml1 at oli1170.net
Sun Jul 19 08:03:14 PDT 2015

Hello Jerome,

Just to let you know that I'm back and a small intermediate status on this 

On Thursday 18 June 2015 23:16:57 Jerome Glisse wrote:
> Anyway as it is your patch would break runtime suspend.
> I recently posted patch to fix the resume side of hibernation, they might
> also help in the freeze()/thaw() dance. Could you please test them without
> your patch :
> https://patchwork.kernel.org/patch/6641371/
> https://patchwork.kernel.org/patch/6641381/

I tested those two patches, but they (at least separately) didn't give an 
s2disk improvement. 

> If it is not enough than also try with attached patch (which i have not
> tested myself but i think the logic is right).

The reworked patch seemed to worked for the s2disk snapshot-taking 
freeze()->thaw(), but the resume() of the restored image didn't work then.

Attached is a patch onto your 0001-drm-radeon-rework-device-power-management-
for-radeon.patch, which basically realigns the logic to the previous flow of my 
initial patch. With this it works ok again. 

In the freeze() case it does again the "unpin the front buffers" part and in 
thaw() in again does "init dig PHYs, disp eng pll" plus what follows. 

I need to test a bit more which is the minimum delta to have it working with 
regards to your patch. 

The attached patch is just for info. It doesn't reindent the code to keep it 
more readable for the time being. 

So I'll continue "tuning" this is a bit. But I do this just on the high-level 
suspend/resume() sequence that I see in the from the existing code. Without 
deeper radeon-hw-reasoning behind. 

BR, Oliver
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-0001-drm-radeon-rework-device-power-management-for-r.patch
Type: text/x-patch
Size: 1783 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-driver-ati/attachments/20150719/46261f8d/attachment.bin>

More information about the xorg-driver-ati mailing list