[Bug 90789] Vsync doesn't work for rotated display

Michel Dänzer michel at daenzer.net
Fri Dec 25 18:36:28 PST 2015


On 26.12.2015 02:39, Richard Wilbur wrote:
> Interesting that in the patch
> --------------------------------------------
> 
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> [...]
> @@ -2253,6 +2317,9 @@ Bool drmmode_set_desired_modes(ScrnInfoPtr
> pScrn, drmmode_ptr drmmode,
>   crtc->desiredY = 0;
>   }
> 
> + if (1 || info->tear_free || info->shadow_primary)
> +    crtc->driverIsPerformingTransform = TRUE;
> +
> --------------------------------------------
> 
> Seems to me this will always short-circuit to true which makes the
> conditional superfluous.

I did say it was a preliminary patch. :)

> I'm guessing there may still be some merit to conditionally setting
> driverIsPerformingTransform but the details simply need to be worked out?

Exactly.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-driver-ati mailing list