[PATCH] Add Option "TearFree"

Michel Dänzer michel at daenzer.net
Mon Apr 20 17:54:14 PDT 2015


On 21.04.2015 06:08, Richard Wilbur wrote:
> On Mon, Apr 20, 2015 at 3:54 AM, Michel Dänzer <michel at daenzer.net> wrote:
> [...]
>> diff --git a/src/radeon_kms.c b/src/radeon_kms.c
>> index 64593ab..e18f85a 100644
>> --- a/src/radeon_kms.c
>> +++ b/src/radeon_kms.c
>> @@ -1092,15 +1157,22 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags)
>>      }
>>  #endif
>>
>> +    info->tear_free = xf86ReturnOptValBool(info->Options, OPTION_TEAR_FREE,
>> +                                          FALSE);
>> +
>> +    if (info->shadow_primary)
>> +       xf86DrvMsg(pScrn->scrnIndex, X_CONFIG, "TearFree enabled\n");
>> +
> 
> It seems likely that I don't understand the full implications of
> info->tear_free and info->shadow_primary.  I would have expected the
> message about "TearFree enabled" to be predicated on info->tear_free,
> since that is what we are adding with this patch, as opposed to
> info->shadow_primary, which doesn't seem to be touched by the new
> option.

You're absolutely right, thanks for the catch. Copy'n'paste accident. :)
Fixed in v2.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-driver-ati mailing list