[PATCH] Rename Option "NoAccel" to "Accel"

[Alex Deucher]

On Wed, Jun 4, 2014 at 4:00 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Removes the need for a double negation when forcing acceleration on.
>
> Note that this change is backwards compatible, as the option parser
> automagically handles the 'No' prefix.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


> ---
>  man/radeon.man   | 8 ++++----
>  src/radeon.h     | 2 +-
>  src/radeon_kms.c | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/man/radeon.man b/man/radeon.man
> index 65b880c..802f6c2 100644
> --- a/man/radeon.man
> +++ b/man/radeon.man
> @@ -225,12 +225,12 @@ are supported:
>  Selects software cursor.  The default is
>  .B off.
>  .TP
> -.BI "Option \*qNoAccel\*q \*q" boolean \*q
> +.BI "Option \*qAccel\*q \*q" boolean \*q
>  Enables or disables all hardware acceleration.
>  .br
> -The default is to
> -.B enable
> -hardware acceleration.
> +The default is
> +.B on
> +except for HAWAII.
>  .TP
>  .BI "Option \*qZaphodHeads\*q \*q" string \*q
>  Specify the RandR output(s) to use with zaphod mode for a particular driver
> diff --git a/src/radeon.h b/src/radeon.h
> index 136a430..eac6ed5 100644
> --- a/src/radeon.h
> +++ b/src/radeon.h
> @@ -135,7 +135,7 @@
>  #endif
>
>  typedef enum {
> -    OPTION_NOACCEL,
> +    OPTION_ACCEL,
>      OPTION_SW_CURSOR,
>      OPTION_PAGE_FLIP,
>      OPTION_EXA_PIXMAPS,
> diff --git a/src/radeon_kms.c b/src/radeon_kms.c
> index ceaf575..707d0c7 100644
> --- a/src/radeon_kms.c
> +++ b/src/radeon_kms.c
> @@ -59,7 +59,7 @@ extern SymTabRec RADEONChipsets[];
>  static Bool radeon_setup_kernel_mem(ScreenPtr pScreen);
>
>  const OptionInfoRec RADEONOptions_KMS[] = {
> -    { OPTION_NOACCEL,        "NoAccel",          OPTV_BOOLEAN, {0}, FALSE },
> +    { OPTION_ACCEL,          "Accel",            OPTV_BOOLEAN, {0}, FALSE },
>      { OPTION_SW_CURSOR,      "SWcursor",         OPTV_BOOLEAN, {0}, FALSE },
>      { OPTION_PAGE_FLIP,      "EnablePageFlip",   OPTV_BOOLEAN, {0}, FALSE },
>      { OPTION_COLOR_TILING,   "ColorTiling",      OPTV_BOOLEAN, {0}, FALSE },
> @@ -499,8 +499,8 @@ static Bool RADEONPreInitAccel_KMS(ScrnInfoPtr pScrn)
>         info->is_fast_fb = TRUE;
>      }
>
> -    if (xf86ReturnOptValBool(info->Options, OPTION_NOACCEL,
> -                            info->ChipFamily == CHIP_FAMILY_HAWAII) ||
> +    if (!xf86ReturnOptValBool(info->Options, OPTION_ACCEL,
> +                            info->ChipFamily != CHIP_FAMILY_HAWAII) ||
>         (!RADEONIsAccelWorking(pScrn))) {
>         xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>                    "GPU accel disabled or not working, using shadowfb for KMS\n");
> --
> 2.0.0
>
> _______________________________________________
> xorg-driver-ati mailing list
> xorg-driver-ati at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-ati