[PATCH] Revert "glamor: Set environment variable RADEON_THREAD=0"

Alex Deucher alexdeucher at gmail.com
Wed Aug 20 06:21:42 PDT 2014


On Wed, Aug 20, 2014 at 4:53 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> This reverts commit 4b5060f357a3cb248c9359c92c1e9c42ef6434c8.
>
> Further testing shows that disabling the thread is only a moderate win in
> some cases, but a much bigger loss in some other cases.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/radeon_glamor.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c
> index 02fa658..210ddcf 100644
> --- a/src/radeon_glamor.c
> +++ b/src/radeon_glamor.c
> @@ -132,16 +132,6 @@ radeon_glamor_pre_init(ScrnInfoPtr scrn)
>                         "Incompatible glamor version, required >= 0.3.0.\n");
>                         return FALSE;
>                 } else {
> -                       /* This prevents the Gallium radeon winsys from spawning
> -                        * a separate thread for submitting command streams to
> -                        * the kernel. Improves scores of at least gtkperf and
> -                        * x11perf -putimage/-shmput/-getimage/-shmget, probably
> -                        * because glamor causes too many command stream flushes
> -                        * / too much synchronization with pending command
> -                        * streams for the separate thread to pay off.
> -                        */
> -                       setenv("RADEON_THREAD", "0", 0);
> -
>                         if (glamor_egl_init(scrn, info->dri2.drm_fd)) {
>                                 xf86DrvMsg(scrn->scrnIndex, X_INFO,
>                                            "glamor detected, initialising EGL layer.\n");
> --
> 2.1.0
>
> _______________________________________________
> xorg-driver-ati mailing list
> xorg-driver-ati at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-ati


More information about the xorg-driver-ati mailing list