[PATCH] radeon: fix use-after-free in modesetting cleanup

Michel Dänzer michel at daenzer.net
Tue Apr 22 23:12:24 PDT 2014


On 23.04.2014 12:40, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> noticed while looking at something else.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/drmmode_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index fc99128..f22f198 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -966,8 +966,8 @@ drmmode_output_destroy(xf86OutputPtr output)
>  	}
>  	for (i = 0; i < drmmode_output->mode_output->count_encoders; i++) {
>  		drmModeFreeEncoder(drmmode_output->mode_encoders[i]);
> -		free(drmmode_output->mode_encoders);
>  	}
> +	free(drmmode_output->mode_encoders);
>  	free(drmmode_output->props);
>  	drmModeFreeConnector(drmmode_output->mode_output);
>  	free(drmmode_output);
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer


More information about the xorg-driver-ati mailing list