radeonsi & glamor small glitches

[Igor Vagulin]

On 03/27/13 15:49, Michel Dänzer wrote:
> Fix posted for review:
> http://lists.freedesktop.org/archives/mesa-dev/2013-March/036772.html
Patch fixes problem for me.
> Looks like XFCE is hitting an extremely slow path in glamor, but it does finish eventually for me.
> Probably file a bug against glamor.
Just in case. I gathered sysprof stats for this case, attached as 
xfce-logout-hang.prof.
>> >      - many gtkperf tests is slower than exa(I believe means shadowfb?).
>> >For example GtkDrawingArea-Text is 12,44 sec vs 3.08 sec. I can get
>> >oprofile if needed.
> FWIW, I find data from perf or sysprof much more useful than oprofile.
> But the CPU might not be the bottleneck for this anyway, it's generally
> very hard to beat shadowfb across the board.
In case you decide to look into it I attached 2 sysprof screenshots for 
slowest tests: gtkdrawingarea-lines and gtkdrawingarea-text. I am 
attaching screenshots because AFAICU real profiles useless without my 
binaries.

I also hit screen corruption while profiling, reproducible by following 
scenario:
- open sysprog with some non short data, make sure "descendants 
treeview" have scrollbar
- start to scroll "descendants" up and down, screen will corrupt.
> The "glamoregl" module needs to be pre-loaded (along with "dri2") from
> Section "Module". glamor ships a xorg.conf.d snippet for this. Current
> xf86-video-ati Git catches this more gracefully.
Works fine this way. Thank you again. I'd like to say I made attempt to 
exclude incorrect config by trying with config created by "X -configure".

-- 
Igor Vagulin

P.S. I am writing all this letters believing they are helpful, please let me now if they are not desirable.

-------------- next part --------------
ProcCopyArea                                         0.00%  98.77%
  glamor_copy_area                                   0.00%  98.76%
    miDoCopy                                         0.00%  98.76%
      miCopyRegion                                   0.00%  98.76%
        _glamor_copy_n_to_n.part.8                   0.00%  98.76%
          glamor_prepare_access                      0.00%  98.76%
            glamor_download_pixmap_to_cpu            0.00%  98.76%
              glamor_download_sub_pixmap_to_cpu      0.00%  98.76%
                _glamor_download_sub_pixmap_to_cpu   0.00%  98.76%
                  _mesa_ReadPixels                   0.00%  98.75%
                    _mesa_ReadnPixelsARB             0.00%  98.75%
                      st_readpixels                  0.00%  98.75%
                        __memcpy_ssse3              98.73%  98.75%
                        _mesa_readpixels             0.00%   0.00%
                        st_validate_state            0.00%   0.00%
                  _mesa_PixelStorei                  0.00%   0.00%
          __glamor_copy_n_to_n                       0.00%   0.00%
      compSourceValidate                             0.00%   0.00%
  damageCopyArea                                     0.00%   0.01%

-------------- next part --------------
ProcPolySegment                                                0.01%  46.68%
  damagePolySegment                                            0.02%  46.59%
    glamor_poly_segment                                        0.00%  46.28%
      miPolySegment                                            0.01%  46.27%
        _glamor_poly_lines                                     0.02%  46.25%
          glamor_prepare_access                                0.00%  34.99%
            glamor_download_pixmap_to_cpu                      0.02%  34.99%
              glamor_download_sub_pixmap_to_cpu                0.02%  34.85%
                _glamor_download_sub_pixmap_to_cpu             0.03%  34.77%
                  _mesa_ReadPixels                             0.00%  34.33%
                    _mesa_ReadnPixelsARB                       0.02%  34.32%
                      st_readpixels                            0.00%  34.01%
                        _mesa_readpixels                      30.75%  33.57%
-------------- next part --------------
Dispatch                                                  0.26%  51.95%
  ProcRenderDispatch                                      0.00%  49.32%
    ProcRenderCompositeGlyphs                             0.17%  30.64%
      CompositeGlyphs                                     0.00%  29.92%
        damageGlyphs                                      0.20%  29.81%
          _glamor_glyphs.isra.12                          0.89%  27.38%
            glamor_glyphs_flush_dst                       0.02%  25.61%
              glamor_composite_glyph_rects                0.20%  25.55%
                glamor_composite_with_shader              1.85%  25.09%
                  glamor_flush_composite_rects            0.00%  13.07%
                  - - kernel - -                          3.41%   3.41%
                  glamor_composite_set_shader_blend       0.09%   2.04%
                  glamor_set_destination_pixmap_priv_nc   0.00%   1.65%
                  glamor_setup_composite_vbo              0.07%   0.80%
                  _mesa_BindBuffer                        0.13%   0.54%
                  _mesa_UseProgram                        0.07%   0.43%
                  glamor_set_normalize_tcoords_generic    0.39%   0.39%
                  _mesa_Disable                           0.04%   0.26%