[PATCH 1/2] Bug 72849 - first argument to drmOpen() is a no-op

Michel Dänzer michel at daenzer.net
Thu Dec 19 18:06:02 PST 2013

On Don, 2013-12-19 at 11:49 +0000, Robert Millan wrote:
> Subject: [PATCH] Set first parameter to drmOpen() as NULL to avoid misleading
>  readers into thinking it actually loads a kernel module.

This summary line is too long. The Git commit log format convention is:
Short summary (no more than ~80 characters), blank line, detailed
description. The short summary is what appears in the output of git
shortlog and should give a rough idea of what the change does.

> For details see: https://bugs.freedesktop.org/show_bug.cgi?id=72849

The details need to be in the Git commit log itself. The convention for
referencing bug reports is:

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72849

> diff --git a/src/radeon_kms.c b/src/radeon_kms.c
> index 44a0139..21a420f 100644
> --- a/src/radeon_kms.c
> +++ b/src/radeon_kms.c
> @@ -607,7 +607,7 @@ static Bool radeon_open_drm_master(ScrnInfoPtr pScrn)
>                       dev->domain, dev->bus, dev->dev, dev->func);
>  #endif
> -    info->dri2.drm_fd = drmOpen("radeon", busid);
> +    info->dri2.drm_fd = drmOpen(NULL, busid);
>      if (info->dri2.drm_fd == -1) {
>         xf86DrvMsg(pScrn->scrnIndex, X_ERROR,

The change itself looks good to me. Please resend with a fixed commit
log. BTW, in general patches submitted for inclusion should have a
Signed-off-by: tag.

Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer

More information about the xorg-driver-ati mailing list