[PATCH/RFC v2 0/10] Re: avivotool: error out unless there is exactly one control and fb region

Jonathan Nieder jrnieder at gmail.com
Fri Feb 24 19:41:37 PST 2012

Alex Deucher wrote:

> region 0 is always the frame buffer and region 2 is always mmio.
> radeontool and avivotool should be cleaned up the same way radeonreg
> is.

Thanks, makes perfect sense.  Here's a reroll that does that.

The motivation is still patches 7 (libpciaccess API churn) and 10
(unfriendly behavior when run as non-root).  The rest of the patches
are cleanups or small potential improvements noticed in the process of
writing those two.

Still untested, since my radeon is still temporarily out of
commission.  Compiles at least. :)

Jonathan Nieder (10):
  avivotool: make card detection and mapping errors non-fatal
  avivotool, radeonreg: make fatal errors exit
  use continue statement to simplify "for each PCI device" loop
  avivotool, radeonreg: completely skip early cards with --skip
  exit "for each PCI device" loop as soon as Radeon device is found
  radeontool, avivotool: remove unnecessary region autodetection magic
  switch to modern pci_device_map_range API
  include errno string in more messages
  radeontool: document functions that require mapped control region
  radeontool: make card detection and mapping errors non-fatal

 avivotool.c  |  134 ++++++++++++++++++++++++++++--------------------------
 configure.ac |    2 +-
 radeonreg.c  |   69 ++++++++++++++++------------
 radeontool.c |  143 ++++++++++++++++++++++++++++++++++------------------------
 4 files changed, 196 insertions(+), 152 deletions(-)

More information about the xorg-driver-ati mailing list