[PATCH/RFC radeontool 0/5] Re: Only print current status in usage() if we are root

Jonathan Nieder jrnieder at gmail.com
Mon Feb 20 23:15:28 PST 2012

Hi Tormod,

Tormod Volden wrote:

> [Subject: Only print current status in usage() if we are root]

Sorry to take so long to get to this.  Here's a series that covers
two topics.  Patches 4 and 5/5 are intended to be in the same spirit
and mostly cover the same ground as your patches concerning running
radeontool as non-root.

Patches 1-3 squash a -Wdeprecated-declarations warning.  Patch 1 makes
die() fatal again --- I had been assuming it was fatal before, and the
lack of that was just generally scary to me --- and patch 2 is another
"tighten up the error handling to make the code less frightening to
modify" patch, but ultimately they are both designed to make patch 3,
which moves to the modern libpciaccess API, more comfortable to write.

All that is unrelated to patches 4 and 5.  Sorry about that --- I can
send them separately if that's useful.  Anyway, these last two patches
are meant to make radeontool more approachable by being a little
more helpful when run without appropriate privileges.

More thoughts on each patch in their respective messages.

Untested, since the screen's broken on my laptop with a radeon.  Test
results and other thoughts would be very welcome.

What do you think?
Jonathan Nieder (5):
  avivotool, radeonreg: make fatal errors exit
  avivotool: error out unless there is exactly one control and fb region
  switch to modern pci_device_map_range API
  make some error messages more verbose
  radeontool: make card detection and mapping errors non-fatal

 avivotool.c  |   84 ++++++++++++++++++++++++++----------------
 configure.ac |    2 +-
 radeonreg.c  |   41 ++++++++++++++-------
 radeontool.c |  113 ++++++++++++++++++++++++++++++++++++++--------------------
 4 files changed, 155 insertions(+), 85 deletions(-)

More information about the xorg-driver-ati mailing list