[PATCH 1/2] KMS: Fix output properties logic error.

Michel Dänzer michel at daenzer.net
Fri May 13 00:16:41 PDT 2011


On Don, 2011-05-12 at 10:41 -0400, Alex Deucher wrote: 
> 2011/5/12 Michel Dänzer <michel at daenzer.net>:
> > From: Michel Dänzer <daenzer at vmware.com>
> >
> > Pointed out by clang:
> >
> > ../../src/drmmode_display.c:1023:30: error: use of logical && with constant operand; switch to bitwise & or remove constant [-Werror,-Wconstant-logical-operand]
> >                if (props && (props->flags && DRM_MODE_PROP_ENUM)) {
> >                                           ^  ~~~~~~~~~~~~~~~~~~
> 
> Reviewed-by: Alex Deucher <alexdeucher at gmail.com>

Pushed, thanks for the review.


What about the other patch? If you think it's too risky, we could just
remove the second error assignment, as it's currently a no-op?


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-driver-ati mailing list