[Bug 32188] radeon evergreen (5xxx) segfault (Komodo Edit, other apps)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32188

--- Comment #40 from Alex Deucher <agd5f at yahoo.com> 2011-01-23 21:05:42 PST ---
So all the issues seem to be fixed by the patch in comment 38 according to
feedback on IRC.  My current hypothesis is that we end up mapping the cbuf bo
in PrepareSolid() or PrepareComposite(), then never end up adding any verts to
the vbo, or never end up calling DoneSolid() or DoneComposite().  Perhaps an
EXA bug in some versions of the xserver?  If that cbuf is indeed the problem,
this patch should also fix the issues:

diff --git a/src/radeon_kms.c b/src/radeon_kms.c
index fbdb530..4297f6b 100644
--- a/src/radeon_kms.c
+++ b/src/radeon_kms.c
@@ -91,7 +91,7 @@ void radeon_cs_flush_indirect(ScrnInfoPtr pScrn)
     }

     /* release the current VBO so we don't block on mapping it later */
-    if (info->accel_state->cbuf.vb_offset && info->accel_state->cbuf.vb_bo) {
+    if (info->accel_state->cbuf.vb_bo) {
         radeon_vbo_put(pScrn, &info->accel_state->cbuf);
         info->accel_state->cbuf.vb_start_op = -1;
     }
@@ -108,14 +108,6 @@ void radeon_cs_flush_indirect(ScrnInfoPtr pScrn)
     if (ret)
       ErrorF("space check failed in flush\n");

-    if (accel_state->cbuf.vb_bo) {
-       ret = radeon_cs_space_check_with_bo(info->cs,
-                                           accel_state->cbuf.vb_bo,
-                                           RADEON_GEM_DOMAIN_GTT, 0);
-       if (ret)
-           ErrorF("space check failed in flush\n");
-    }
-
     if (info->reemit_current2d && info->state_2d.op)
         info->reemit_current2d(pScrn, info->state_2d.op);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.