[Bug 32188] radeon evergreen (5xxx) segfault (Komodo Edit, other apps)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32188

--- Comment #38 from Alex Deucher <agd5f at yahoo.com> 2011-01-23 12:51:46 PST ---
(In reply to comment #30)
> X doesn't crash anymore, but there are still bo in the reserved/wait list with
> a ptr and they sometimes get reused.

I still can't understand how we get an unmapped bo with a ptr on the list.  Did
anyone get the corruption issues with any of the previous workarounds?

Does this patch make any difference?

diff --git a/src/radeon_kms.c b/src/radeon_kms.c
index fbdb530..bfc9584 100644
--- a/src/radeon_kms.c
+++ b/src/radeon_kms.c
@@ -85,13 +85,13 @@ void radeon_cs_flush_indirect(ScrnInfoPtr pScrn)
        return;

     /* release the current VBO so we don't block on mapping it later */
-    if (info->accel_state->vbo.vb_offset && info->accel_state->vbo.vb_bo) {
+    if (info->accel_state->vbo.vb_bo) {
         radeon_vbo_put(pScrn, &info->accel_state->vbo);
         info->accel_state->vbo.vb_start_op = -1;
     }

     /* release the current VBO so we don't block on mapping it later */
-    if (info->accel_state->cbuf.vb_offset && info->accel_state->cbuf.vb_bo) {
+    if (info->accel_state->cbuf.vb_bo) {
         radeon_vbo_put(pScrn, &info->accel_state->cbuf);
         info->accel_state->cbuf.vb_start_op = -1;
     }

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.