[PATCH] video: Don't round up bottom/right edge for clipping source width/height.
michel at daenzer.net
Thu Aug 11 07:58:05 PDT 2011
On Don, 2011-08-11 at 10:51 -0400, Alex Deucher wrote:
> 2011/8/11 Michel Dänzer <michel at daenzer.net>:
> > From: Michel Dänzer <michel.daenzer at amd.com>
> > It's not necessary: If the top/left edge was rounded down, this will be
> > compensated by the subtraction.
> > Worse, if the original source width/height is odd, rounding up may result in
> > reading past the end of the source data.
> > Fixes http://bugs.debian.org/637258 .
> > Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> > ---
> > Am I missing a reason why this would be necessary?
> I have some vague recollection of the overlay needing some kind of
> special alignment, but I could be wrong.
I think that would need to be handled differently anyway, as we can't
copy more data than there is...
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
More information about the xorg-driver-ati