[Bug 30451] error: ‘struct _ScrnInfoRec’ has no member named ‘pixmapPrivate’

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Oct 12 15:45:24 PDT 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30451

--- Comment #22 from Witold Baryluk <baryluk at smp.if.uj.edu.pl> 2010-10-12 15:45:24 PDT ---
It looks that commit
commit 5c6a2f93ebc16a78093782b442306de23ae94e78
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Mon Sep 27 19:39:23 2010 +0100

    xfree86: Kill pixmapPrivate with a vengeance (v2)

    ScrnInfo->pixmapPrivate only existed in order to catch invalid access to
    the framebuffer by making the backing data NULL across the VT switch.
    This was causing more confusion in the higher layers during mode setting
    without any real benefit, so remove it.

    v2: Kill ShadowModifyPixmapHeader() as well.

...

removed pixmapPrivate from  struct _ScrnInfoRec in
xserver/hw/xfree86/common/xf86str.h

Author of the line in mesa which references (indicatted by git blame
mesa/src/gallium/state_trackers/xorg/xorg_driver.c ) is

commit 6749310d...
Jakob Bornecrantz 2010-01-25 20:07:43 +0100

There is also a comment, which reads

    /* This a hack to work around EnableDisableFBAccess setting the pointer
     * the real fix would be to replace pScrn->EnableDisableFBAccess hook
     * and set the rootPixmap->devPrivate.ptr to something valid before that.
     *
     * But in its infinit visdome something uses either this some times before
     * that, so our hook doesn't get called before the crash happens.
     */
    pScrn->pixmapPrivate.ptr = ptr;



Apperently removing pScrn->pixmapPrivate.ptr = ptr, do not hurt...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the xorg-driver-ati mailing list