[Bug 31339] HP/Compaq 8510w HDMI port only works when booted with monitor attached

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31339

--- Comment #14 from Tyson Whitehead <twhitehead at gmail.com> 2010-11-05 11:43:10 PDT ---
Created an attachment (id=40073)
 View: https://bugs.freedesktop.org/attachment.cgi?id=40073
 Review: https://bugs.freedesktop.org/review?bug=31339&attachment=40073

Patch to add (likely) missing complements in masking operations used to update
DDC and clock/data mux

Hey Alex,

It seemed that this must be related to the DDC mux, so I had a quick look
through the code I2C mux code.  The masking operations seemed suspect as they
effectively did either

val &= 0x06  (ddc_mux_control_pin)
val |= 0x04  (ddc_mux_state)

or

val &= 0x06  (ddc_mux_control_pin)
val |= 0x02  (ddc_mux_state)

That really seemed like it should be

val &= 0xf9  (~ddc_mux_control_pin)
val |= 0x04  (ddc_mux_state)

or

val &= 0xf9  (~ddc_mux_control_pin)
val |= 0x02  (ddc_mux_state)

so I switched the masking to use the complements, and everything works now!

Thanks again for all your hard work on this.  It's great to finally have open
source drivers for a state-of-the-art video card.

Cheers!  -Tyson

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.