[PATCH radeontool 0/7] r128 support

Jonathan Nieder jrnieder at gmail.com
Tue Mar 23 19:50:04 PDT 2010


Hi,

Ever since the libpciaccess conversion, radeontool no longer
supports r128 cards.  I don’t know if it is necessarily a
goal for it to, but radeontool 1.5 did and some people used
it to work around problems with the backlight staying on when
suspending on Dell laptops.

These patches fix it for me.  Thanks to Tormod Volden for the
help (see <http://bugs.debian.org/572168>).

Patch 3 lets radeontool notice a control region as small as 16 KiB
(which is what my card uses; the old radeontool just grepped lspci
output for "Memory" and "K" to find it) and a framebuffer as small as
64 MiB.

The first two patches make radeontool complain more loudly about
unsupported cards.  It seems possible that on some strange Radeon
these more lax requirements might confuse radeontool; patch 4 makes it
error out instead.

With patch 3 applied, radeontool light on|off works fine for me, but
radeontool regmatch '*' locked up the system.  Patches 5-6 make such a
lockup more bearable; I used them while debugging.  Patch 7 fixes it.

I hope you enjoy the patches.  I would be interested in any comments
you have.

Regards,
Jonathan Nieder (7):
  radeontool: completely skip early cards with --skip
  radeontool: error out for missing control or fb region
  radeontool: handle r128 again
  radeontool: error out for too many control or fb regions
  radeontool regmatch: print name before reading each register
  radeontool regmatch: sync() before reading a bunch of registers
  Avoid lockup on ‘radeontool regmatch '*'’ on r128

 radeontool.c |   50 +++++++++++++++++++++++++++++++++++++++++---------
 1 files changed, 41 insertions(+), 9 deletions(-)



More information about the xorg-driver-ati mailing list