[Bug 29065] X segfault due to radeon trying to process in reqblank on a client that is freed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29065

--- Comment #12 from Oldrich Jedlicka <oldium.pro at seznam.cz> 2010-08-26 11:08:56 PDT ---
(In reply to comment #10)
> Created an attachment (id=38139)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38139
 Review: https://bugs.freedesktop.org/review?bug=29065&attachment=38139

> the option 2 version of the vblank when client gone fix.

The patch (option 2) looks good and works for me; I like the used idea ;-)

I have one question - I'm not sure if the method radeon_dri2_screen_init is the
right place to call AddCallback, because it should be called once per server
instance. dixRegisterPrivateKey can be called more times, it doesn't reserve
the space twice. But I have to admit that I don't know how many times the
method radeon_dri2_screen_init could be called (on the multi-head setup for
example) - how many screens could you have on one xorg-server instance...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.