[PATCH 3/3] Make consistent use of fbOffset and share fb mappings.

[Owain Ainsworth]

On Mon, Apr 19, 2010 at 04:05:36AM +0100, Owain G. Ainsworth wrote:
> What we were doing previously was mapping the framebuffer for zaphod for
> only this driver instances chunk, however, fbOffset was (rightly) set to
> the offset into the whole framebuffer we were using.
> 
> Since in some cases we did operations on the FB virtual address +
> fbOffset (for example zeroing the framebuffer on entervt) we were
> actually pissing all over ourselves in those cases.
> 
> Fix this by implementing shared fb mappings like we do for MMIO already,
> and whenever we wish to refer to our area of FB space we always use
> fbOffset. Fixes zaphod for some users on r600 chipsets, my 4870 is still
> behaving strangely on screen 0, but I suspect that is another bug.
> 
> Once calculation (in PreInitAccel) is now wrong because of this, however
> dri on zaphod does now happen so this is irrelavent, add a comment to
> that effect.

Airlied expressed concern that leaking fb on server recycle was probably
a bad idea, so I'd like to add the following patch to the series: