[PATCH] Mark highly predictable branches as likely/unlikely

Matt Turner mattst88 at gmail.com
Wed Apr 7 16:25:24 PDT 2010


On Wed, Apr 7, 2010 at 7:15 PM, Dave Airlie <airlied at redhat.com> wrote:
> On Wed, 2010-04-07 at 18:49 -0400, Matt Turner wrote:
>> Highly predicatble branches include
>>  - unlikely: error conditions, such as those leading to
>>       - RADEON_FALLBACK
>>       - goto fail
>>       - return FALSE (as an error
>>  - likely: if (info->useEXA)
>
> Can we limit these to fastpaths?
>
> i.e. no need in atombios or drmmode code or anywhere like that.
>
> I expect you just want it in the accel/exa/xv codepaths.
>
> Dave.

Sure. I can strip out the others and resend if you'd like, or you
could just commit the parts you think are appropriate. I don't imagine
there would be any ill effects from including the patch for files like
 src/atombios_output.c            |    2 +-
 src/drmmode_display.c            |    6 +-
though. This wasn't a blind find'n'replace, so the ones included
should be pretty good.

Thanks,
Matt


More information about the xorg-driver-ati mailing list