[PATCH] Remove spurious register access

Luca Tettamanti kronos.it at gmail.com
Wed Feb 4 12:25:17 PST 2009


When saving the state of the card AVIVO_D*GRPH_CONTROL registers are
read twice without any apparent reason (there are no documented side
effects).
Remove the spurious access.

Signed-off-by: Luca Tettamanti <kronos.it at gmail.com>

diff --git a/src/radeon_driver.c b/src/radeon_driver.c
index b0817b0..c6e1df4 100644
--- a/src/radeon_driver.c
+++ b/src/radeon_driver.c
@@ -4278,7 +4278,6 @@ avivo_save(ScrnInfoPtr pScrn, RADEONSavePtr save)
 
     state->grph1.enable = INREG(AVIVO_D1GRPH_ENABLE);
     state->grph1.control = INREG(AVIVO_D1GRPH_CONTROL);
-    state->grph1.control = INREG(AVIVO_D1GRPH_CONTROL);
     state->grph1.prim_surf_addr = INREG(AVIVO_D1GRPH_PRIMARY_SURFACE_ADDRESS);
     state->grph1.sec_surf_addr = INREG(AVIVO_D1GRPH_SECONDARY_SURFACE_ADDRESS);
     state->grph1.pitch = INREG(AVIVO_D1GRPH_PITCH);
@@ -4319,7 +4318,6 @@ avivo_save(ScrnInfoPtr pScrn, RADEONSavePtr save)
 
     state->grph2.enable = INREG(AVIVO_D2GRPH_ENABLE);
     state->grph2.control = INREG(AVIVO_D2GRPH_CONTROL);
-    state->grph2.control = INREG(AVIVO_D2GRPH_CONTROL);
     state->grph2.prim_surf_addr = INREG(AVIVO_D2GRPH_PRIMARY_SURFACE_ADDRESS);
     state->grph2.sec_surf_addr = INREG(AVIVO_D2GRPH_SECONDARY_SURFACE_ADDRESS);
     state->grph2.pitch = INREG(AVIVO_D2GRPH_PITCH);


Luca
-- 
"New processes are created by other processes, just like new
 humans. New humans are created by other humans, of course,
 not by processes." -- Unix System Administration Handbook


More information about the xorg-driver-ati mailing list