[Bug 14783] New: xorg/driver/xf86-video-r128 - Avoid usage of LoaderSymbol

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=14783

           Summary: xorg/driver/xf86-video-r128 - Avoid usage of
                    LoaderSymbol
           Product: xorg
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: Driver/Radeon
        AssignedTo: xorg-driver-ati at lists.x.org
        ReportedBy: pcpa at mandriva.com.br
         QAContact: xorg-team at lists.x.org


Created an attachment (id=14769)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=14769)
0001-Avoid-usage-of-LoaderSymbol.patch

It can be dangerous. This patch is based on the previous one when r128
was in xf86-video-ati. The problem is that if gR128EntityIndex is not
explicitly marked as a public symbol, and weird things may happen when
compiling with hidden symbols.
Since the symbol is in the same shared binary of its callers, just use
it, instead of using LoaderSymbol. Could also just replace calls
getR128EntityIndex() to direct access to gR128EntityIndex.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.