[Bug 14594] xf86-video-ati 6.8. 0 uses #pragma pack incorrectly--server fails to load

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=14594





--- Comment #4 from Michel Dänzer <michel at tungstengraphics.com>  2008-02-21 06:27:43 PST ---
(In reply to comment #2)
> Created an attachment (id=14481)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=14481) [details]
> remove -DFGL_LINUX from src/Makefile.am

NACK - you expect developers on Linux to think of any potential implications of
their changes on other OSs, but you didn't even bother looking up the change
which added the flag with something like git-blame? Not defining FGL_LINUX
causes build warnings on Linux. It looks like the code currently guarded by it
needs to be diversified - as Alex pointed out, the ATOM BIOS code was
previously only used on Windows and Linux.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.