[Bug 14594] New: xf86-video-ati 6.8. 0 uses #pragma pack incorrectly--server fails to load

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=14594

           Summary: xf86-video-ati 6.8.0 uses #pragma pack incorrectly--
                    server fails to load
           Product: xorg
           Version: unspecified
          Platform: x86 (IA32)
        OS/Version: NetBSD
            Status: NEW
          Severity: critical
          Priority: medium
         Component: Driver/Radeon
        AssignedTo: xorg-driver-ati at lists.x.org
        ReportedBy: bjs at NetBSD.org
         QAContact: xorg-team at lists.x.org


The xf86-video-ati 6.8.0 driver is configured to build with -DFGL_LINUX.  This
results in incorrect use of #pragma pack for many platforms.  The test platform
in this case is NetBSD/i386 4.99.54.

Symptomatology:

The server starts, but never makes it past a blank screen--the characteristic
"flicker" I noticed while [presumably] modes are being probed [for RandR] does
not occur.  While the system does not hang, I nevertheless cannot switch VTs. 
Thankfully, I had no problem shutting down the system properly via the ACPI
power button.

At first, I could think of no reason why this should be happening.  Then, I
noticed that -DFGL_LINUX is defined in the default CFLAGS--irrespective of
platform.  This [I believe] resulted in incorrect alignment of structure
members in the AtomBIOS headers.

Upon removing this definition and building the code with my platform's
defaults, the driver worked well (and thanks for the r300 acceleration, I'm
very happy to finally have it).

While I am aware that developers can only test software on machines they use, I
kindly ask that in the future that at least things as obvious as a linux
"FireGL specific" uses of #pragma pack are employed less capriciously.  The
NetBSD project has a very competent developer who, if given commit access,
would be happy to assist in [coordinating and conducting] testing on NetBSD's
many supported architectures (and pkgsrc's many supported platforms) to ease
the burden on other developers.  Moreover, I would think that testing Xorg code
on many additional platforms could only result in more robust code.

Best Regards,

--Blair Sadewitz
<bjs at NetBSD.org>


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.