[Bug 13274] XVideo 24bit RGB image causes server crash.

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13274





------- Comment #2 from michel at tungstengraphics.com  2007-11-21 05:34 PST -------
Thanks for the patch.

> -		src += hpass * srcPitch;
> -		dptr += hpass * bufPitch;
> +		src += srcPitch;
> +		buf += bufPitch;

Looks like this is the essential fix? It shouldn't be necessary to add the buf
variable though.


> -	      dptr[0]=((sptr[0])<<24)|((sptr[1])<<16)|(sptr[2]);
> +#if X_BYTE_ORDER == X_BIG_ENDIAN
> +	      dptr[0]=((sptr[0])<<16)|((sptr[1])<<8)|(sptr[2]);
> +#else
> +	      dptr[0]=((sptr[2])<<16)|((sptr[1])<<8)|(sptr[0]);
> +#endif

Are you sure these changes are correct for both byte orders? Is your system big
or little endian?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.