[PATCH] Fetch clock info before setting up connectors

Alex Deucher alexdeucher at gmail.com
Sat Jun 2 11:29:43 PDT 2007


Committed.

Thanks for tracking this down!

Alex

On 6/2/07, Paul TBBle Hampson <Paul.Hampson at pobox.com> wrote:
> RADEONProbePLLParameters sets pll->reference_div, and
> RADEONGetPanelInfoFromReg uses it.
>
> This ensures that the former is called before the latter.
> ---
>  src/radeon_driver.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/radeon_driver.c b/src/radeon_driver.c
> index 925b8ee..1c433e2 100644
> --- a/src/radeon_driver.c
> +++ b/src/radeon_driver.c
> @@ -2497,14 +2497,14 @@ static Bool RADEONPreInitControllers(ScrnInfoPtr pScrn, xf86Int10InfoPtr  pInt10
>
>      RADEONGetBIOSInfo(pScrn, pInt10);
>
> +    RADEONGetClockInfo(pScrn);
> +
>      if (!RADEONSetupConnectors(pScrn)) {
>         return FALSE;
>      }
>
>      RADEONPrintPortMap(pScrn);
>
> -    RADEONGetClockInfo(pScrn);
> -
>      for (i = 0; i < config->num_output; i++)
>      {
>        xf86OutputPtr          output = config->output[i];
> --
> 1.5.2
>
> This is for branch randr-1.2, and fixes the problem that
> appeared in 117220527de9fd3158f600645bcfcaf46847f45f for
> BIOS-less cards.
>
> Basically, the lack of BIOS made RADEONGetPanelInfoFromReg
> fall back onto the probed reference_div, which had not yet
> been probed.
>
> I hope this formats OK, it's my first use of git-format-patch.
>
> --
> -----------------------------------------------------------
> Paul "TBBle" Hampson, B.Sc, LPI, MCSE
> On-hiatus Asian Studies student, ANU
> The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
> Paul.Hampson at Pobox.com
>
> Of course Pacman didn't influence us as kids. If it did,
> we'd be running around in darkened rooms, popping pills and
> listening to repetitive music.
>  -- Kristian Wilson, Nintendo, Inc, 1989
>
> License: http://creativecommons.org/licenses/by/2.1/au/
> -----------------------------------------------------------
>
> _______________________________________________
> xorg-driver-ati mailing list
> xorg-driver-ati at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-driver-ati
>
>
>


More information about the xorg-driver-ati mailing list