Bug#392833: XAA and RenderAccel causes visual glitches

[Loïc Minier]

Package: xserver-xorg-video-ati
Version: 1:6.6.2-2
Severity: normal
Tags: patch

        Hi,

 I'm pushing gtk2-engines 2.8 to testing, and it exposes a bug with the
 ati driver when using XAA and RenderAccel is on.  Here's a full log
 with various pointers:
    <https://launchpad.net/distros/ubuntu/+source/xserver-xorg-video-ati/+bug/34435/>
 see also:
    <https://launchpad.net/distros/ubuntu/+source/xserver-xorg-video-ati/+bug/38198>

 Xorg fixed this in an upstream commit:
    <http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=commitdiff_plain;h=84e574986f61c4f250d6ecb938bab20847618906;hp=487376cce72ef8f19b4e3dc742b53500bed7c480>

 I'm attaching a patch to the Debian source for your convenience.  It
 would be nice if you could apply it.  (I may NMU if you desire, please
 state so.)

    Bye,

-- System Information:
Debian Release: Debian unstable (sid)
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-1-686
Locale: LANG=fr_FR at euro, LC_CTYPE=fr_FR at euro (charmap=ISO-8859-15)

Versions of packages xserver-xorg-video-ati depends on:
ii  libc6                        2.3.6.ds1-6 GNU C Library: Shared libraries
ii  xserver-xorg-core            2:1.1.1-9   X.Org X server -- core server

xserver-xorg-video-ati recommends no packages.

-- no debconf information

-- 
Loïc Minier <lool at dooz.org>
-------------- next part --------------
--- xserver-xorg-video-ati-6.6.2/debian/patches/series
+++ xserver-xorg-video-ati-6.6.2/debian/patches/series
@@ -1,0 +2 @@
+02_ati_xaa_fallback_render_repeat.patch
--- xserver-xorg-video-ati-6.6.2/debian/changelog
+++ xserver-xorg-video-ati-6.6.2/debian/changelog
@@ -1,3 +1,13 @@
+xserver-xorg-video-ati (1:6.6.2-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * New patch, 02_ati_xaa_fallback_render_repeat; from upstream git
+    http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git
+    commit 7d9e2b450f0fa42553156f57572a6dab70a0ea13; fixes render glitches
+    when using RenderAccel and XAA.
+
+ -- Loic Minier <lool at dooz.org>  Fri, 13 Oct 2006 20:53:11 +0200
+
 xserver-xorg-video-ati (1:6.6.2-2) unstable; urgency=low
 
   [ Drew Parsons ]
--- xserver-xorg-video-ati-6.6.2.orig/debian/patches/02_ati_xaa_fallback_render_repeat.patch
+++ xserver-xorg-video-ati-6.6.2/debian/patches/02_ati_xaa_fallback_render_repeat.patch
@@ -0,0 +1,26 @@
+Index: xserver-xorg-video-ati-6.6.2/src/radeon_render.c
+===================================================================
+--- xserver-xorg-video-ati-6.6.2.orig/src/radeon_render.c	2006-10-13 20:52:27.000000000 +0200
++++ xserver-xorg-video-ati-6.6.2/src/radeon_render.c	2006-10-13 20:52:41.000000000 +0200
+@@ -392,6 +392,10 @@
+ #endif
+     ACCEL_PREAMBLE();
+ 
++    /* render repeat is broken - fix in stable tree by falling back */
++    if (flags & XAA_RENDER_REPEAT)
++	return FALSE;
++
+     if ((width > 2048) || (height > 2048))
+ 	return FALSE;
+ 
+@@ -725,6 +729,10 @@
+ #endif
+     ACCEL_PREAMBLE();
+ 
++    /* render repeat is broken - fix in stable tree by falling back */
++    if (flags & XAA_RENDER_REPEAT)
++	return FALSE;
++
+     if ((width > 2048) || (height > 2048))
+ 	return FALSE;
+