<div dir="ltr">Tested-by: Mike Lothian <<a href="mailto:mike@fireburn.co.uk">mike@fireburn.co.uk</a>></div> <div class="gmail_quote"><div dir="ltr">On Mon, 16 Apr 2018 at 20:33 Louis-Francis Ratté-Boulianne <<a href="mailto:lfrb@collabora.com">lfrb@collabora.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks Mario for spotting that. On Mon, 2018-04-16 at 08:14 +0200, Mario Kleiner wrote: > Sending pixmap depth and bpp was omitted, so the Mesa > X11 + EGL + DRI3 side of things always failed to > dri3_create_image_khr_pixmap_from_buffers(), which led > to failure of X11 + EGL compositing under DRI3 under, > e.g., KDE Plasma 5. > > Fixes: 6e7c40f62db6 ("dri3: Add multi-planar/modifier buffer > requests") > Signed-off-by: Mario Kleiner <<a href="mailto:mario.kleiner.de@gmail.com" target="_blank">mario.kleiner.de@gmail.com</a>> > Cc: Daniel Stone <<a href="mailto:daniels@collabora.com" target="_blank">daniels@collabora.com</a>> Reviewed-by: Louis-Francis Ratté-Boulianne <<a href="mailto:lfrb@collabora.com" target="_blank">lfrb@collabora.com</a>> > --- > dri3/dri3_request.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/dri3/dri3_request.c b/dri3/dri3_request.c > index 2d3deb2..452b08a 100644 > --- a/dri3/dri3_request.c > +++ b/dri3/dri3_request.c > @@ -481,7 +481,7 @@ proc_dri3_buffers_from_pixmap(ClientPtr client) > int i; > PixmapPtr pixmap; > > - REQUEST_SIZE_MATCH(xDRI3BufferFromPixmapReq); > + REQUEST_SIZE_MATCH(xDRI3BuffersFromPixmapReq); > rc = dixLookupResourceByType((void **) &pixmap, stuff->pixmap, > RT_PIXMAP, > client, DixWriteAccess); > if (rc != Success) { > @@ -497,6 +497,8 @@ proc_dri3_buffers_from_pixmap(ClientPtr client) > rep.length = bytes_to_int32(num_fds * 2 * sizeof(CARD32)); > rep.width = pixmap->drawable.width; > rep.height = pixmap->drawable.height; > + rep.depth = pixmap->drawable.depth; > + rep.bpp = pixmap->drawable.bitsPerPixel; > rep.modifier = modifier; > > if (client->swapped) { _______________________________________________ <a href="mailto:xorg-devel@lists.x.org" target="_blank">xorg-devel@lists.x.org</a>: X.Org development Archives: <a href="http://lists.x.org/archives/xorg-devel" rel="noreferrer" target="_blank">http://lists.x.org/archives/xorg-devel</a> Info: <a href="https://lists.x.org/mailman/listinfo/xorg-devel" rel="noreferrer" target="_blank">https://lists.x.org/mailman/listinfo/xorg-devel</a></blockquote></div>