<div dir="ltr">I've applied this too as part of my testing, I don't see a dri3 file - does that mean the dri2 one covers both dri2&3?<div><br></div><div>If it doesn't please ignore</div><div><br></div><div>Tested-by: Mike Lothian <<a href="mailto:mike@fireburn.co.uk">mike@fireburn.co.uk</a>></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, 16 Apr 2018 at 21:17 Frank Binns <<a href="mailto:frank.binns@imgtec.com">frank.binns@imgtec.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Adam Jackson <<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>> writes:<br>
<br>
> ms_queue_vblank() returns false on failure.<br>
><br>
> Reported-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk" target="_blank">chris@chris-wilson.co.uk</a>><br>
> Signed-off-by: Adam Jackson <<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>><br>
<br>
Reviewed-by: Frank Binns <<a href="mailto:frank.binns@imgtec.com" target="_blank">frank.binns@imgtec.com</a>><br>
<br>
> ---<br>
>  hw/xfree86/drivers/modesetting/dri2.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c<br>
> index fd36aa118..96eaaaaf7 100644<br>
> --- a/hw/xfree86/drivers/modesetting/dri2.c<br>
> +++ b/hw/xfree86/drivers/modesetting/dri2.c<br>
> @@ -749,7 +749,7 @@ ms_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw, CARD64 target_msc,<br>
>              target_msc = current_msc;<br>
>  <br>
>          ret = ms_queue_vblank(crtc, MS_QUEUE_ABSOLUTE, target_msc, &queued_msc, seq);<br>
> -        if (ret) {<br>
> +        if (!ret) {<br>
>              static int limit = 5;<br>
>              if (limit) {<br>
>                  xf86DrvMsg(scrn->scrnIndex, X_WARNING,<br>
<br>
_______________________________________________<br>
<a href="mailto:xorg-devel@lists.x.org" target="_blank">xorg-devel@lists.x.org</a>: X.Org development<br>
Archives: <a href="http://lists.x.org/archives/xorg-devel" rel="noreferrer" target="_blank">http://lists.x.org/archives/xorg-devel</a><br>
Info: <a href="https://lists.x.org/mailman/listinfo/xorg-devel" rel="noreferrer" target="_blank">https://lists.x.org/mailman/listinfo/xorg-devel</a></blockquote></div>