<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Nov 20, 2017 at 9:43 PM, Adam Jackson <span dir="ltr"><<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This was added in ~2004 for the sis driver, to detect whether it could<br>
use SSE for memcpy. Charmingly, the code to check whether that feature<br>
exists in the server is:<br>
<br>
#if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(6,8,99,13<wbr>,0)<br>
#define SISCHECKOSSSE /* Automatic check OS for SSE; requires SigIll facility */<br>
#endif<br>
<br>
Which means it has never worked in any modular server release.<br>
<br>
A less gross way to do this is to check for SSE support with getauxval()<br>
or /proc/cpuinfo or similar. Since no driver is using the existing<br>
intercept mechanism, drop it.<br>
<br>
Signed-off-by: Adam Jackson <<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>><br>
---<br>
hw/xfree86/common/xf86.h | 1 -<br>
hw/xfree86/common/xf86Events.<wbr>c | 13 -------------<br>
2 files changed, 14 deletions(-)<br>
<br>
diff --git a/hw/xfree86/common/xf86.h b/hw/xfree86/common/xf86.h<br>
index 674e83cb1f..db6e299b31 100644<br>
--- a/hw/xfree86/common/xf86.h<br>
+++ b/hw/xfree86/common/xf86.h<br>
@@ -216,7 +216,6 @@ extern _X_EXPORT void xf86EnableGeneralHandler(void *handler);<br>
extern _X_EXPORT InputHandlerProc xf86SetConsoleHandler(InputHan<wbr>dlerProc<br>
handler, void *data);<br>
extern _X_EXPORT void xf86InterceptSignals(int *signo);<br>
-extern _X_EXPORT void xf86InterceptSigIll(void (*sigillhandler) (void));<br>
extern _X_EXPORT void xf86ProcessActionEvent(ActionE<wbr>vent action, void *arg);<br>
extern _X_EXPORT void xf86PrintBacktrace(void);<br>
extern _X_EXPORT Bool xf86VTOwner(void);<br>
diff --git a/hw/xfree86/common/xf86Events<wbr>.c b/hw/xfree86/common/xf86Events<wbr>.c<br>
index 53ec74f261..e2e6ca7691 100644<br>
--- a/hw/xfree86/common/xf86Events<wbr>.c<br>
+++ b/hw/xfree86/common/xf86Events<wbr>.c<br>
@@ -276,14 +276,6 @@ xf86InterceptSignals(int *signo)<br>
*signo = -1;<br>
}<br>
<br>
-static void (*xf86SigIllHandler) (void) = NULL;<br>
-<br>
-void<br>
-xf86InterceptSigIll(void (*sigillhandler) (void))<br>
-{<br>
- xf86SigIllHandler = sigillhandler;<br>
-}<br>
-<br>
/*<br>
* xf86SigWrapper --<br>
* Catch unexpected signals and exit or continue cleanly.<br>
@@ -291,11 +283,6 @@ xf86InterceptSigIll(void (*sigillhandler) (void))<br>
int<br>
xf86SigWrapper(int signo)<br>
{<br>
- if ((signo == SIGILL) && xf86SigIllHandler) {<br>
- (*xf86SigIllHandler) ();<br>
- return 0; /* continue */<br>
- }<br>
-<br>
if (xf86SignalIntercept && (*xf86SignalIntercept < 0)) {<br>
*xf86SignalIntercept = signo;<br>
return 0; /* continue */<br>
<span class="m_-9219417115110248348HOEnZb"><font color="#888888">--<br>
2.14.3<br>
<br>
______________________________<wbr>_________________<br>
<a href="mailto:xorg-devel@lists.x.org" target="_blank">xorg-devel@lists.x.org</a>: X.Org development<br>
Archives: <a href="http://lists.x.org/archives/xorg-devel" rel="noreferrer" target="_blank">http://lists.x.org/archives/xo<wbr>rg-devel</a><br>
Info: <a href="https://lists.x.org/mailman/listinfo/xorg-devel" rel="noreferrer" target="_blank">https://lists.x.org/mailman/li<wbr>stinfo/xorg-devel</a></font></span></blockquote></div></div><div class="gmail_extra"><br></div><div class="gmail_extra">FWIW, I am not an expert of the xfree86 codebase, but if nobody uses that then good riddance!<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Reviewed-by: Olivier Fourdan <<a href="mailto:ofourdan@redhat.com" target="_blank">ofourdan@redhat.com</a>><br></div></div>