buillding error xorg-server 21.1.4

[Alan Coopersmith]

On 10/30/24 12:28, Fungal-net wrote:
>>>>> I get the following error trying to build version 21.1.4
>>>>> same build dependencies used for 21.1.3 (4/13/24) but different versions
>>>>> gcc 14.2.1+r134
>>>>> glibc 2.40+r16
>>>>> binutils 2.43+r4
>>>>> libtool 2.5.3
>>>>>
>>>>> arch linux like system without systemd
>>>>>
>>>>> ../xorg-server/os/access.c: In function ‘siHostnameAddrMatch’:
>>>>> ../xorg-server/os/access.c:1873:27: error: assignment to ‘const char **’ from incompatible pointer type ‘char **’ [-Wincompatible-pointer-types]
>>>>> 1873 | for (addrlist = hp->h_addr_list; *addrlist; addrlist++)
>>>>> | ^
>>>>
>>>> The easy fix is to stop disabling IPv6 support when building Xorg.
>>>>
>>>> But yes, it appears we also should have backported the fix for this issue that
>>>> gcc 14 has made an error:
>>>> https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1572
>>>
>>> Thank you, yes I do recall there was a problem some months ago build Xwayland and although a fix was found the next release didn't include it but a later rc did.
>>> So I will be patient, if an option is provided it should be functional, I am sure you agree. If it wasn't there would have been dirty hacking intervention which we don't want.
>>
>>
>> It was functional for many years (almost two decades), but was broken by
>> gcc 14 raising several issues from warnings to errors. Until the next 21.1.x
>> release you should also be able to add "-Wno-error=incompatible-pointer-types"
>> to your CFLAGS to bypass this if you must build with IPv6 disabled using gcc 14.
> 
> Thank you again, good enough for personal use but altering policy of a distribution
> to accommodate a single package is not a good decision, I think.
> Maybe I could use the xwayland patch to create one for xorg-server for the mean time.

The patches from the merge request I linked above worked fine for me on the 21.1 
branch - you should be able to download them in patch format from
https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1572.patch .
I'm working on a merge request to backport them to the 21.1 branch but hit 
another build failure when testing the build with IPv6 disabled that I'm fixing
first ( https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1736 ).

> Also, if master is a commit from years back (or what its version reveals), what fork
> is used for latest rc?

We don't have any recent release candidate builds, just actual releases.
The 21.1.14 release was made from the server-21.1-branch in git.

-- 
         -Alan Coopersmith-                 alan.coopersmith at oracle.com
          Oracle Solaris Engineering - https://blogs.oracle.com/solaris