Deprecated usage in linux.cf

[Ken Zalewski]

Alan and team,

Thank you for the quick response.  It looks like the _BSD_SOURCE and
_SVID_SOURCE macros were deprecated back in 2015, in glibc 2.19 and
beyond.  Here is more information on the change from { _BSD_SOURCE,
_SVID_SOURCE }  to _DEFAULT_SOURCE:

https://man7.org/linux/man-pages/man7/feature_test_macros.7.html

https://stackoverflow.com/questions/29201515/what-does-d-default-source-do

I modified /usr/lib64/X11/config/linux.cf and made these changes.  I will
be testing these changes as part of the TightVNC build.  I will let you
know if I encounter any issues.

Thank you again,

Ken Zalewski
Troy, NY



On Mon, Jul 18, 2022 at 5:41 PM Alan Coopersmith <
alan.coopersmith at oracle.com> wrote:

> I've cc'ed the xorg-devel mailing list to reach the other X.Org developers,
> as I primarily work on Solaris, not Linux, myself.
>
> I have no objection to such a change, and would accept a merge request [1]
> to
> do it from someone who can test it, but I don't know if there needs to be
> any sort of version check to use the older defines on older releases, and
> the newer defines on newer ones, or even if we could check that in Imake,
> since I believe it depends on the GNU libc version, not the Linux version.
>
> Really though, TightVNC needs to move to a modern build system if it wants
> to build on modern platforms, because we're not really maintaining Imake
> and haven't done so in many years now.
>
>         -alan-
>
> [1] https://gitlab.freedesktop.org/xorg/util/cf/-/merge_requests
>
> On 7/18/22 12:58, Ken Zalewski wrote:
> > Hi Alan,
> >
> > I saw that you released xorg-cf-files 1.0.7 back in 2021, via this
> archived email:
> > https://lists.x.org/archives/xorg-announce/2021-August/003105.html
> > <https://lists.x.org/archives/xorg-announce/2021-August/003105.html>
> >
> > I realize that the Imake system is antiquated, but it is still necessary
> to
> > build TightVNC on Linux.  I wanted to point out that GCC now issues a
> > deprecation warning when using -D_BSD_SOURCE and -D_SVID_SOURCE.  I
> believe the
> > correct define is now -D_DEFAULT_SOURCE.
> >
> > I tracked this down to the file:
> > /usr/lib64/X11/config/linux.cf <http://linux.cf>
> >
> > When I modify lines 241 and 260 to replace "-D_BSD_SOURCE
> -D_SVID_SOURCE" with
> > "-D_DEFAULT_SOURCE", I no longer receive the deprecation notices.
> >
> > Would it be possible to issue a new minor release of xorg-cf-files with
> this fix?
> >
> > Thank you,
> >
> > Ken Zalewski
> > Troy, NY
> >
> >
> >
> >
>
>
> --
>          -Alan Coopersmith-                 alan.coopersmith at oracle.com
>           Oracle Solaris Engineering - https://blogs.oracle.com/solaris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20220718/8a939b6f/attachment.htm>