Leak in XKeysymToString

[Alan Coopersmith]

On 8/20/22 18:20, Po Lu wrote:
> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
> 
>> Thanks - while gitlab is our preferred method, when that's not possible,
>> we prefer using the xorg-devel mailing list (cc'ed) instead of trying to
>> guess which individual developer to contact.
> 
> Thanks for explaining.  I thought xorg-devel was shut down and replaced
> by Discourse, but I'm probably confusing it with GNOME lists.

Right - GNOME did that, but X.Org still uses mailing lists.

>> If they do, then perhaps a safer fix would be to keep a list of the
>> returned strings and reuse the pointer when the same keysym is seen again
>> instead of continuing to allocate new memory each time.
> 
> Probably in an assoc table or similar structure, right?  Using a plain
> list seems horribly inefficient once XKeysymToString is called for
> enough keysyms.

Right.

-- 
         -Alan Coopersmith-                 alan.coopersmith at oracle.com
          Oracle Solaris Engineering - https://blogs.oracle.com/solaris