xscope fixes

Alan Coopersmith alan.coopersmith at oracle.com
Tue Dec 7 18:47:35 UTC 2021


On 12/6/21 11:59 PM, Thomas Klausner wrote:
> When updating the pkgsrc patches to 1.4.2, I noticed quite a lot of warnings.
> Here are patches that remove most.

Thanks - since we've switched from email to gitlab for patch submission, I've
converted these to a merge request at:
https://gitlab.freedesktop.org/xorg/app/xscope/-/merge_requests/5

> ../fd.c: In function ‘MainLoop’:
> ../fd.c:432:1: warning: function might be candidate for attribute ‘noreturn’ [-Wsuggest-attribute=noreturn]
>    432 | MainLoop(void)
>        | ^~~~~~~~
> 
> is unfixed since I could mark it _X_NORETURN but then I'd have to remove
> the "return 0" at the end too -- is tha tok?

I think so.

-- 
         -Alan Coopersmith-                 alan.coopersmith at oracle.com
          Oracle Solaris Engineering - https://blogs.oracle.com/solaris


More information about the xorg-devel mailing list