[PATCH libXmu v2 1/2] Remove support for XA_IP_ADDRESS

[Thomas Dickey]

On Wed, Jan 15, 2020 at 08:54:10AM +0100, Matthieu Herrb wrote:
> On Tue, Jan 14, 2020 at 06:29:52PM -0500, Thomas Dickey wrote:
> > On Tue, Jan 14, 2020 at 10:23:15PM +0100, Matthieu Herrb wrote:
> > > This code has a number of issues:
> > > - It doesn't support IPv6 https://bugs.freedesktop.org/show_bug.cgi?id=7611
> > > - The IP address is set by the selection owner so it doesn't bring any
> > >   security for anyone querying the selection
> > > - The extra DNS query that it does is problematic in some sandboxed
> > >   environments (like OpenBSD's pledge
> > >   https://marc.info/?l=openbsd-bugs&m=157842725819911&w=2)
> > > 
> > > Signed-off-by: Matthieu Herrb <matthieu at herrb.eu>
> > > ---
> > >  src/CvtStdSel.c | 30 ++----------------------------
> > >  1 file changed, 2 insertions(+), 28 deletions(-)
> > 
> > The documentation should be updated as well.
> 
> Oh yes, you're right. I think the patch below is enough. Or should
> we mention explicitely that IP_ADDRESSS is now deprecated ?

I think so (explaining why it was removed from the result),
since (looking for mention of the feature) it seems that
was the primary manner in which it was used over the past 30 years...
 
> From eb1b1c9fd4336bd2b92e8bbb174f8d829a9dac89 Mon Sep 17 00:00:00 2001
> From: Matthieu Herrb <matthieu at herrb.eu>
> Date: Wed, 15 Jan 2020 07:55:53 +0100
> Subject: [PATCH] doc: IP_ADDRESS is not converted by
>  XmuConvertStandardSelection anymore.
> 
> Signed-off-by: Matthieu Herrb <matthieu at herrb.eu>
> ---
>  doc/Xmu.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/Xmu.xml b/doc/Xmu.xml
> index 2d363a9..fdd60e0 100644
> --- a/doc/Xmu.xml
> +++ b/doc/Xmu.xml
> @@ -1442,7 +1442,7 @@ returns the size in bits of the elements</para>
>        </variablelist>
>  
>  This function converts the following standard selections: CLASS,
> -CLIENT_WINDOW, DECNET_ADDRESS, HOSTNAME, IP_ADDRESS, NAME, OWNER_OS,
> +CLIENT_WINDOW, DECNET_ADDRESS, HOSTNAME, NAME, OWNER_OS,
>  TARGETS, TIMESTAMP, and USER.  It returns
>  <symbol>True</symbol>
>  if the conversion was successful, else it returns
> -- 
> 2.24.1
> 
> 
> 
> 
> -- 
> Matthieu Herrb



-- 
Thomas E. Dickey <dickey at invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20200115/a3c7c0f4/attachment.sig>