xorg-xserver/Xext/shm.c - missing swapped case?

[Ulrich Sibiller]

On Mon, May 6, 2019 at 6:28 PM Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
>
> On 5/6/19 9:20 AM, Ulrich Sibiller wrote:
> > Since that code is really old (the PANORAMIX stuff came in with
> > XFree86 4.3.0.1 in November 2003) I am wondering if this really a bug
> > or if am missing something crucial here?
>
> I don't think X has ever truly supported a platform on which clients
> of different endianess can share memory - shared memory is typically
> local only, while endian swapping is typically remote only.

I agree. So the current situation is that the code is
a) incomplete
b) never used

IMHO consequently all the swapping code should be dropped from shm.c.
Swapped requests (wherever they come from) should simply return an
error then.

Uli