[PATCH 0/9] Fix some of LGTM warnings
Konstantin Kharlamov
Hi-Angel at yandex.ru
Sat Mar 23 23:51:54 UTC 2019
This fixes some of the warnings reported here:
https://lgtm.com/projects/g/mirror/xserver/alerts/?mode=tree
I don't plan at the moment to address the rest of them, in case someone
else wants to take a look.
Konstantin Kharlamov (9):
exa: fix "comparison is always false"
xfree86: numTimings is never value other than 0
Xext: the check firstValuator ≤ 1 is duplicated in this branch
xkbtext: fix copy-paste error
glx: remove a noop assert (index is unsigned)
modesetting: don't pass a big struct by value
fdi2iclass.py: use "is" to compare with None
fdi2iclass: remove unused local variable
gen_gl_wrappers: remove unused imports
Xext/xtest.c | 2 +-
config/fdi2iclass.py | 5 +----
exa/exa_driver.c | 2 +-
exa/exa_mixed.c | 4 +---
glx/vndservermapping.c | 1 -
hw/xfree86/common/xf86Mode.c | 18 ++++--------------
.../drivers/modesetting/drmmode_display.c | 10 +++++-----
hw/xwin/glx/gen_gl_wrappers.py | 2 +-
xkb/xkbtext.c | 2 +-
9 files changed, 15 insertions(+), 31 deletions(-)
--
2.21.0
More information about the xorg-devel
mailing list