[PATCH xf86-video-cirrus] Declare an I2C bus name string as a static type for alp_i2c.c (walter harms)

[Kevin Brace]

Hi Walter,

I am attempting to eliminate compilation warnings from the code.
The previous code causes "const char*" to "char*" compilation warnings.
That's all.

Regards,

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com


> Date: Thu, 18 Jul 2019 09:02:52 +0200
> From: walter harms <wharms at bfs.de>
> To: xorg-devel at lists.x.org
> Subject: Re: [PATCH xf86-video-cirrus] Declare an I2C bus name string
> 	as a static type for alp_i2c.c
> Message-ID: <5D30199C.6060904 at bfs.de>
> Content-Type: text/plain; charset=UTF-8
>
> HI,
> thx for your patch,
> would you like to explain why ?
> what problem do you try to solve ?
>
>
> re,
>  wh
>
> Am 18.07.2019 04:55, schrieb Kevin Brace:
> > Signed-off-by: Kevin Brace <kevinbrace at gmx.com>
> > ---
> >  src/alp_i2c.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/alp_i2c.c b/src/alp_i2c.c
> > index 9341543..b52f2c8 100644
> > --- a/src/alp_i2c.c
> > +++ b/src/alp_i2c.c
> > @@ -16,6 +16,11 @@
> >  #define _ALP_PRIVATE_
> >  #include "alp.h"
> >
> > +
> > +static char strI2CBus1[]	= "I2C bus 1";
> > +static char strI2CBus2[]	= "I2C bus 2";
> > +
> > +
> >  /*
> >   * Switch between internal I2C bus and external (DDC) bus.
> >   * There is one I2C port controlled bu SR08 and the programmable
> > @@ -99,7 +104,7 @@ AlpI2CInit(ScrnInfoPtr pScrn)
> >
> >  	pCir->I2CPtr1 = I2CPtr;
> >
> > -	I2CPtr->BusName    = "I2C bus 1";
> > +	I2CPtr->BusName    = strI2CBus1;
> >  	I2CPtr->scrnIndex  = pScrn->scrnIndex;
> >  	I2CPtr->I2CPutBits = AlpI2CPutBits;
> >  	I2CPtr->I2CGetBits = AlpI2CGetBits;
> > @@ -113,7 +118,7 @@ AlpI2CInit(ScrnInfoPtr pScrn)
> >
> >  	pCir->I2CPtr2 = I2CPtr;
> >
> > -	I2CPtr->BusName    = "I2C bus 2";
> > +	I2CPtr->BusName    = strI2CBus2;
> >  	I2CPtr->scrnIndex  = pScrn->scrnIndex;
> >  	I2CPtr->I2CPutBits = AlpI2CPutBits;
> >  	I2CPtr->I2CGetBits = AlpI2CGetBits;
> > --
> > 2.17.1
> >
> > _______________________________________________
> > xorg-devel at lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: https://lists.x.org/mailman/listinfo/xorg-devel
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> https://lists.x.org/mailman/listinfo/xorg-devel
>
> ------------------------------
>
> End of xorg-devel Digest, Vol 126, Issue 8
> ******************************************
>