[PATCH xorgproto] XF86keysym: Add XF86XK_MonBrightnessCycle

[Hans de Goede]

Hi,

Thank you for your patch.

On 04-01-19 04:36, Jian-Hong Pan wrote:
> Jian-Hong Pan <jian-hong at endlessm.com> 於 2018年11月28日 週三 下午5:07寫道：
>>
>> Add XF86XK_MonBrightnessCycle keysym, to be used as mapping for evdev's
>> KEY_BRIGHTNESS_CYCLE keycode which is generated from ACPI video module's
>> ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS on some Acer AIO desktop buttons.
>> The button changes the screen's brightness on Windows.
>>
>> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=108861
>> Signed-off-by: Jian-Hong Pan <jian-hong at endlessm.com>
>> ---
>>   include/X11/XF86keysym.h | 11 ++++++-----
>>   1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/X11/XF86keysym.h b/include/X11/XF86keysym.h
>> index 771fbb0..9ad8948 100644
>> --- a/include/X11/XF86keysym.h
>> +++ b/include/X11/XF86keysym.h
>> @@ -23,11 +23,12 @@
>>   #define XF86XK_ModeLock                0x1008FF01      /* Mode Switch Lock */
>>
>>   /* Backlight controls. */
>> -#define XF86XK_MonBrightnessUp   0x1008FF02  /* Monitor/panel brightness */
>> -#define XF86XK_MonBrightnessDown 0x1008FF03  /* Monitor/panel brightness */
>> -#define XF86XK_KbdLightOnOff     0x1008FF04  /* Keyboards may be lit     */
>> -#define XF86XK_KbdBrightnessUp   0x1008FF05  /* Keyboards may be lit     */
>> -#define XF86XK_KbdBrightnessDown 0x1008FF06  /* Keyboards may be lit     */
>> +#define XF86XK_MonBrightnessUp    0x1008FF02  /* Monitor/panel brightness */
>> +#define XF86XK_MonBrightnessDown  0x1008FF03  /* Monitor/panel brightness */
>> +#define XF86XK_KbdLightOnOff      0x1008FF04  /* Keyboards may be lit     */
>> +#define XF86XK_KbdBrightnessUp    0x1008FF05  /* Keyboards may be lit     */
>> +#define XF86XK_KbdBrightnessDown  0x1008FF06  /* Keyboards may be lit     */
>> +#define XF86XK_MonBrightnessCycle 0x1008FF07  /* Monitor/panel brightness */
>>
>>   /*
>>    * Keys found on some "Internet" keyboards.
>> --
>> 2.11.0
>>
> 
> Gentle ping.  Any additional information for this patch is required?

No extra info required. Just waiting for someone to get around to it.

I needed to do some XF86keysym.h myself anyways, so I've taken a look and this
looks good to me:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

I've commit rights, so I've added and pushed this right away :)

I've one favor to add, I'm about to submit an XF86keysym.h patch myself,
can you review that please (and reply with a Reviewed-by if the patch
looks good to you) ?

I will Cc you on the patch.

Thanks & Regards,

Hans