[PATCH] result parameter for ScreenWakeupHandlerProcPtr should be unsigned long

[Kevin Brace]

Hi Dave,

I do see what is going on, but was there a mistake in the X Server header file when the ABI was changed?
Who else uses ScreenWakeupHandlerProcPtr and does another device driver have this issue?

Regards,

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com


> Sent: Thursday, January 03, 2019 at 3:14 PM
> From: "Dave Airlie" <airlied at gmail.com>
> To: "Kevin Brace" <kevinbrace at gmx.com>
> Cc: xorg-devel <xorg-devel at lists.x.org>
> Subject: Re: [PATCH] result parameter for ScreenWakeupHandlerProcPtr should be unsigned long
>
> On Fri, 14 Dec 2018 at 06:47, Kevin Brace <kevinbrace at gmx.com> wrote:
> >
> > The result parameter defined inside scrnintstr.h for
> > ScreenWakeupHandlerProcPtr should be unsigned long type not int type.
> > This led to wrong pointer type compilation warnings when compiling S3
> > Savage DDX Version 2.3.9 for ABI_VIDEODRV_VERSION >= 23.
> >
> > Signed-off-by: Kevin Brace <kevinbrace at gmx.com>
> 
> I think Alan already mentioned this, but it should just be fixed in the driver.
> 
> Dave.
> 
> > ---
> >  include/scrnintstr.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/scrnintstr.h b/include/scrnintstr.h
> > index 9b663fa..111cab5 100644
> > --- a/include/scrnintstr.h
> > +++ b/include/scrnintstr.h
> > @@ -278,7 +278,7 @@ typedef void (*ScreenBlockHandlerProcPtr) (ScreenPtr pScreen,
> >   * > 0 - activity
> >   */
> >  typedef void (*ScreenWakeupHandlerProcPtr) (ScreenPtr pScreen,
> > -                                            int result);
> > +                                            unsigned long result);
> >
> >  typedef Bool (*CreateScreenResourcesProcPtr) (ScreenPtr /*pScreen */ );
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > xorg-devel at lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: https://lists.x.org/mailman/listinfo/xorg-devel
>