[PATCH xserver v3] xwayland: Remove xwl_present_window from privates on cleanup

[Lionel Landwerlin]

On 05/09/2018 11:44, Olivier Fourdan wrote:
> Hi,
>
> On Wed, Sep 5, 2018 at 12:05 PM Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> On 05/09/2018 09:49, Olivier Fourdan wrote:
>>> [...]
>>> This is because `xwl_present_cleanup()` frees the memory but does not
>>> remove it from the window's privates, and `xwl_present_abort_vblank()`
>>> will still find it and hence try to access that freed memory...
>>>
>>> Remove `xwl_present_window` from window's privates on cleanup so that no
>>> other function can find and reuse that data once it's freed.
>>>
>>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1616269
>>
>> We also have this fdo bug :
>> https://bugs.freedesktop.org/show_bug.cgi?id=107314
> Yeap, I know about this bug and the patch you sent, but the backtrace
> is different, it doesn't occur on DestroyWindow(), so I doubt this is
> the same (unless you tried my fix and it fixes your issue as well...)
>
> Cheers,
> Olivier
> _______________________________________________


Oops indeed.