[PATCH] dix/window: Use ConfigureWindow instead of MoveWindow

[Adam Jackson]

On Mon, 2018-11-12 at 13:51 +0100, Michal Srb wrote:
> The screensaver can regularly move its window to random offsets. It should
> use the ConfigureWindow function instead of calling the Screen's MoveWindow
> directly. Some MoveWindow implementations, such as compMoveWindow, rely on
> Screen's ConfigNotify being called first as it happens in ConfigureWindow.
> ---
> This fixes abort from assertion failure if compositing is used together with
> screensaver configured using "xset s 2 1 s noblank" command.
> 
> The compCopyWindow function would abort because of:
> 
>   assert(cw->oldx != COMP_ORIGIN_INVALID);
> 
> Because the cw->oldx is set from compReallocPixmap which is only called
> from compConfigNotify.
> 
> Alternatively, if the MoveWindow is supposed to work independently, the
> compMoveWindow must be adapted to handle the case when oldx/oldy is
> set to COMP_ORIGIN_INVALID.

Nah, ConfigNotify is expected before MoveWindow, this patch looks good.
Merged, thanks.

- ajax