last call for 1.20 (was Re: [PATCH xserver] present: fix msc offset calculation in window mode)

[Mario Kleiner]

Hi ajax,

this one just sent out: "[PATCH xserver] modesetting: Remove
ms_crtc_msc_to_kernel_msc().", should really make it into server 1.20,
as it did bad things during my testing yesterday.

Looking at the counterpart ms_kernel_msc_to_crtc_msc() in current
modesetting-ddx makes me a bit nervous as well, but i don't know yet
if for a good reason. modesetting-ddx in server 1.20 uses the new
kernel sequence api's introduced in Linux 4.15 if they are available.
As a consequence, that remapping function has to deal with a wild
mixture of 32 bit msc's (from kernel pageflip completion events, which
are still 32 bit only) and 64 bit msc's from the new sequence api's
for vblank queries and vblank events, which are 64 bit. So i wonder if
the 32-bit wraparound handling in that function is fully prepared to
deal with a random mix of 32-Bit values with possible wraparound and
64 bit values.

Just to say, there might be another vblank fixup patch coming for 1.20.

I also haven't had time to test multi-display and multi-x-screen with
the new modesetting-ddx yet. Has anybody else tested that?

thanks,
-mario


On Wed, May 2, 2018 at 9:31 PM, Adam Jackson <ajax at nwnk.net> wrote:
> On Wed, 2018-05-02 at 14:58 -0400, Adam Jackson wrote:
>
>> I'll push out 1.20 shortly, I think things are about as well-baked as
>> they're going to get. We can always do stable releases if we need them.
>
> Roman has poked me on IRC asking for another day to look into this, so
> 1.20 won't be today. Please shout loudly if there's any other patches
> you want reviewed before it goes out.
>
> - ajax
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel