[PATCH xserver 2/4] dri3: Robustly clamp to 1.0 if not all screens support 1.2

Emil Velikov emil.l.velikov at gmail.com
Tue May 1 15:33:53 UTC 2018


On 30 April 2018 at 08:06, Mario Kleiner <mario.kleiner.de at gmail.com> wrote:
> Checking for dri3_screen_info_rec.version >= 2 is insufficient,
> as some shipping drivers, e.g., intel-ddx, nouveau-ddx, set the
> version to DRI3_SCREEN_INFO_VERSION, ie. to whatever version the
> installed servers headers define.

Hey, at least ati/amdgpu does it properly ;-)

Although in practise there are enough cases/bugs where drivers set the
version they're build against.
Instead of the one they support/implement.

Just grep for VERSION - anythings that's not a preprocessor guard
should be fixed.
Guess we should fix those one of these days.

FWIW series looks spot-on, though I can see it's already merged.
Emil


More information about the xorg-devel mailing list