[PATCH xserver] Don't delete GLX's extensionInitCallback list during a reset.

Adam Jackson ajax at redhat.com
Wed Mar 28 19:06:05 UTC 2018


On Fri, 2018-03-02 at 17:58 -0700, Kyle Brenneman wrote:
> When a callback list is initialized using CreateCallbackList via AddCallback,
> the list gets added to the listsToCleanup array, and as a result the list gets
> deleted at the end of the server generation.
> 
> But, vendor libraries add themselves to that callback list only once, not once
> per generation, so if you delete the list, then no vendor will register itself
> on the next generation, and GLX breaks.
> 
> Instead, use a static CallbackListRec for the extensionInitCallback list. That
> way, it doesn't get added to listsToCleanup, and doesn't get deleted during a
> reset.

Yeah, this works. This is kind of why I'd wanted to see each screen
register its own provider during init, though the swrast fallback
problem makes that less awesome. Still, merged, thanks:

remote: I: patch #207871 updated using rev 16639ab77d14cecb7d03fd2d5c796c2fb1714c18.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   7004a7c3c9..16639ab77d  master -> master

- ajax


More information about the xorg-devel mailing list