[PATCH xserver] exa: promise not to touch the data when swapping pointers

[Adam Jackson]

On Wed, 2018-03-14 at 15:37 +0000, Emil Velikov wrote:
> On 13 March 2018 at 10:55, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> >      swap(pExaGC, pGC, funcs);
> >           ^
> > 
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > ---
> >  exa/exa_priv.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/exa/exa_priv.h b/exa/exa_priv.h
> > index ca4db720fbe871b50b7e..912e214789adba95c7fa 100644
> > --- a/exa/exa_priv.h
> > +++ b/exa/exa_priv.h
> > @@ -244,7 +244,7 @@ extern DevPrivateKeyRec exaScreenPrivateKeyRec;
> >  }
> >  #else
> >  #define swap(priv, real, mem) {\
> > -    void *tmp = priv->Saved##mem; \
> > +    const void *tmp = priv->Saved##mem; \
> 
> Hmm what compiler are you using - any clang/gcc should hit the HAVE_TYPEOF case.
> Regardless, the patch is spot on:
> 
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Merged,thanks:

remote: Updating patchwork state for https://patchwork.freedesktop.org/project/Xorg/list/
remote: I: patch #210087 updated using rev 610055809f4030bd0e7312c6b0c561fdfe6e0183.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   d36128a72a..610055809f  master -> master

- ajax