[PATCH xserver] present: cap the version returned to the client

Keith Packard keithp at keithp.com
Wed Mar 21 15:02:32 UTC 2018


Julien Cristau <jcristau at debian.org> writes:

> Doesn't this break when e.g. client supports 2.2 and server supports
> 1.4, where we'll return 2.2 instead of 1.4?  i.e. it seems to me this
> should be
>
> if (rep.majorVersion > stuff->majorVersion ||
>     (rep.majorVersion == stuff->majorVersion &&
>      rep.minorVersion > stuff->minorVersion)) {
>      ...
> }

Yeah, probably. Of course, we will "never" have a major version change
as that would indicate an incompatible change in the protocol.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180321/afd3c3da/attachment.sig>


More information about the xorg-devel mailing list