[PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

Alan Coopersmith alan.coopersmith at oracle.com
Wed Mar 7 22:53:20 UTC 2018


On 03/ 7/18 01:42 PM, Emil Velikov wrote:
> On 7 March 2018 at 20:10, Alan Coopersmith <alan.coopersmith at oracle.com> wrote:
>> That should be effectively equivalent, just less change in indentation for
>> the lines in between.
>>
> You're correct - it's functionally identical although it seems cleaner.

While the patch seems cleaner & simpler this way, I think the version in my
original patch results in the final code being cleaner and more straightforward
to understand without having to trace where goto's are jumping to, and that's
more important long-term than the patch itself.

> Regardless of which version you opt for
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks,

	-alan-


More information about the xorg-devel mailing list