[PATCH:xserver] Revert "modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD"

Alan Coopersmith alan.coopersmith at oracle.com
Sun Mar 4 21:16:22 UTC 2018


On 03/ 4/18 01:00 PM, Alan Coopersmith wrote:
> Alternatively, you could remove the #ifdef XSERVER_PLATFORM_BUS around the
> #include "xf86platformBus.h" since that header defines XF86_PDEV_SERVER_FD
> before checking #ifdef XSERVER_PLATFORM_BUS itself.

Sorry, spoke too soon - alternative doesn't work either:

driver.c: In function ‘probe_hw’:
driver.c:246:14: error: implicit declaration of function
‘xf86_platform_device_odev_attributes’; did you mean
‘xf86platformAddGPUDevices’? [-Werror=implicit-function-declaration]
         fd = xf86_platform_device_odev_attributes(platform_dev)->fd;
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              xf86platformAddGPUDevices
driver.c:246:14: warning: nested extern declaration of
‘xf86_platform_device_odev_attributes’ [-Wnested-externs]
driver.c:246:64: error: invalid type argument of ‘->’ (have ‘int’)
         fd = xf86_platform_device_odev_attributes(platform_dev)->fd;
                                                                ^~

-- 
	-Alan Coopersmith-               alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - https://blogs.oracle.com/alanc


More information about the xorg-devel mailing list