[PATCH xserver v2 1/2] glamor: Unbreak glamor_fd_from_pixmap()

Daniel Stone daniel at fooishbar.org
Thu Jun 21 07:38:54 UTC 2018


Hey Lyude,
On Thu, 21 Jun 2018 at 00:13, Lyude Paul <lyude at redhat.com> wrote:
> -    /* Pixmaps with multi-planes/modifier are not supported in this interface */
> -    if (ret != 1 || offsets[0] != 0) {
> -        while (ret > 0)
> -            close(fds[--ret]);
> +    ret = _glamor_fds_from_pixmap(screen, pixmap, &fd, &stride32, NULL, size,
> +                                  NULL);
> +    if (ret != 1)
>          return -1;

This needs the removed code just above it, where it closes excess FDs.
I think the rest looks good though; I don't have a PRIME system so
wasn't able to test at the time.

Cheers,
Daniel


More information about the xorg-devel mailing list